Skip to content

Conversation

@jfroche
Copy link
Collaborator

@jfroche jfroche commented Nov 6, 2025

Add test to verify that all extension versions from PostgreSQL 15 can successfully upgrade to PostgreSQL 17 using pg_upgrade.

The test now validates:

  • Each PG 15 extension version can be upgraded to PG 17
  • Extension update scripts are properly generated during upgrade
  • Version handling works correctly with and without update scripts
  • Final extension versions match expected values after upgrade

@samrose samrose self-requested a review November 6, 2025 20:29
Copy link
Collaborator

@samrose samrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will just need to test before we merge it

@jfroche jfroche marked this pull request as ready for review November 6, 2025 22:57
@jfroche jfroche requested review from a team as code owners November 6, 2025 22:57
@jfroche jfroche force-pushed the feat/test-pg-upgrade-older-version branch from 8acfa60 to f59c791 Compare November 7, 2025 16:33
@yvan-sraka yvan-sraka force-pushed the feat/test-pg-upgrade-older-version branch from f59c791 to 779090b Compare November 11, 2025 16:17
@yvan-sraka yvan-sraka self-assigned this Nov 11, 2025
@yvan-sraka yvan-sraka requested a review from samrose November 11, 2025 16:17
@yvan-sraka yvan-sraka force-pushed the feat/test-pg-upgrade-older-version branch 2 times, most recently from 24d66bb to 164f401 Compare November 19, 2025 10:13
@yvan-sraka yvan-sraka marked this pull request as draft November 19, 2025 21:13
Add test to verify that all extension versions from PostgreSQL 15 can successfully upgrade to PostgreSQL 17 using pg_upgrade.

The test now validates:

- Each PG 15 extension version can be upgraded to PG 17
- Extension update scripts are properly generated during upgrade
- Version handling works correctly with and without update scripts
- Final extension versions match expected values after upgrade
…ade compatibility

When upgrading PostgreSQL versions, pg_upgrade needs access to old extension
versions sql to migrate from. This adds unsupported pg_graphql versions (those not
compilable with current PostgreSQL) as SQL-only packages, ensuring migration
paths exist when upgrading from older PostgreSQL versions.
…pgrade compatibility

When upgrading PostgreSQL versions, pg_upgrade needs access to old extension
versions sql to migrate from. This adds unsupported pg_graphql versions (those not
compilable with current PostgreSQL) as SQL-only packages, ensuring migration
paths exist when upgrading from older PostgreSQL versions.
@yvan-sraka yvan-sraka force-pushed the feat/test-pg-upgrade-older-version branch from 164f401 to 450b690 Compare November 21, 2025 10:38
@yvan-sraka yvan-sraka marked this pull request as ready for review November 21, 2025 13:03
When upgrading from PostgreSQL 15 to 17, pg_stat_monitor version 1.0
(PG 15-only) cannot be migrated as it uses .sql.in template files that
reference MODULE_PATHNAME without proper processing for the target version.

This marks version 1.0 as not pg_upgrade compatible and filters it from
the version test list, allowing the test to use version 2.1 (which supports
both PG 15 and 17) for pg_upgrade validation instead. Version 1.0 remains
available for PG 15 installations.

Also updates the expected test output for version 2.1's schema changes.
@blacksmith-sh
Copy link

blacksmith-sh bot commented Nov 21, 2025

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
z_17_pg_stat_monitor View Logs


Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants